Hi Stefan,

stefan@datenfreihafen.org wrote on Wed, 20 Sep 2023 20:08:56 +0200:

Hello.

On 18.09.23 17:08, Miquel Raynal wrote:

quoted

Introduce structures to describe peer devices in a PAN as well as a few
related helpers. We basically care about:
- Our unique parent after associating with a coordinator.
- Peer devices, children, which successfully associated with us.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
  include/net/cfg802154.h | 46 +++++++++++++++++++++++++
  net/ieee802154/Makefile |  2 +-
  net/ieee802154/core.c   |  2 ++
  net/ieee802154/pan.c    | 75 +++++++++++++++++++++++++++++++++++++++++
  4 files changed, 124 insertions(+), 1 deletion(-)
  create mode 100644 net/ieee802154/pan.c

diff --git a/include/net/cfg802154.h b/include/net/cfg802154.h
index f79ce133e51a..6c7193b4873c 100644
--- a/include/net/cfg802154.h
+++ b/include/net/cfg802154.h

[...]

quoted

@@ -478,6 +494,11 @@ struct wpan_dev {  
  >   	/* fallback for acknowledgment bit setting */  
  	bool ackreq;
+
+	/* Associations */
+	struct mutex association_lock;
+	struct ieee802154_pan_device *parent;
+	struct list_head children;
  };  
  >   #define to_phy(_dev)	container_of(_dev, struct wpan_phy, dev)  

@@ -529,4 +550,29 @@ static inline const char *wpan_phy_name(struct wpan_phy *phy)
  void ieee802154_configure_durations(struct wpan_phy *phy,
  				    unsigned int page, unsigned int channel);  
  > +/**  
+ * cfg802154_device_is_associated - Checks whether we are associated to any device
+ * @wpan_dev: the wpan device
+ */
+bool cfg802154_device_is_associated(struct wpan_dev *wpan_dev);  

The return value still missing in kdoc. Seems you missed this from my last review. :-)

Oops, I marked it done on my side by mistake. Sorry for that mistake.

[...]

quoted

diff --git a/net/ieee802154/pan.c b/net/ieee802154/pan.c
new file mode 100644
index 000000000000..012b5e821d54
--- /dev/null
+++ b/net/ieee802154/pan.c

@@ -0,0 +1,75 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * IEEE 802.15.4 PAN management
+ *
+ * Copyright (C) 2021 Qorvo US, Inc  

Feel free to extend the copyright years to 2023 as well.

Right, set to 2023.

Thanks,
Miquèl