Thread (7 messages) 7 messages, 4 authors, 2023-09-15

Re: [PATCH iproute2-next 1/2] configure: add the --color option

From: David Ahern <hidden>
Date: 2023-09-15 18:23:36
Also in: bridge

On 9/15/23 9:59 AM, Stephen Hemminger wrote:
On Wed, 13 Sep 2023 19:58:25 +0200
Andrea Claudi [off-list ref] wrote:
quoted
This commit allows users/packagers to choose a default for the color
output feature provided by some iproute2 tools.

The configure script option is documented in the script itself and it is
pretty much self-explanatory. The default value is set to "never" to
avoid changes to the current ip, tc, and bridge behaviour.

Signed-off-by: Andrea Claudi <redacted>
---
More build time config is not the answer either.
Don't want complaints from distribution users about the change.
Needs to be an environment variable or config file.
I liked the intent, and it defaults to off. Allowing an on by default
brings awareness of the usefulness of the color option.

I have applied the patches, so we need either a revert or followup based
on Stephen's objections.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help