Thread (25 messages) 25 messages, 4 authors, 2023-09-14

Re: [PATCH net 1/5] net: tls: handle -EBUSY on async encrypt/decrypt requests

flat view

From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-09-07 01:50:22

On Wed,  6 Sep 2023 19:08:31 +0200 Sabrina Dubroca wrote:
quoted hunk ↗ jump to hunk
--- a/net/tls/tls_sw.c
+++ b/net/tls/tls_sw.c
@@ -196,6 +196,9 @@ static void tls_decrypt_done(void *data, int err)
 	struct sock *sk;
 	int aead_size;
 
+	if (err == -EINPROGRESS)
+		return;
Maybe a comment here clarifying that caller got -EBUSY and the callback
will fire again without an error? The flow is slightly counter-
-intuitive.
quoted hunk ↗ jump to hunk
@@ -443,6 +446,9 @@ static void tls_encrypt_done(void *data, int err)
 	struct sock *sk;
 	int pending;
 
+	if (err == -EINPROGRESS)
+		return;
Same here? 

Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help