Re: [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator

On 2023/8/7 9:41, Ping-Ke Shih wrote:

quoted

-----Original Message-----
From: Ruan Jinjie <redacted>
Sent: Friday, August 4, 2023 11:54 AM
To: sgoutham@marvell.com; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
jesse.brandeburg@intel.com; anthony.l.nguyen@intel.com; tariqt@nvidia.com; s.shtylyov@omp.ru;
aspriel@gmail.com; franky.lin@broadcom.com; hante.meuleman@broadcom.com; kvalo@kernel.org;
richardcochran@gmail.com; yoshihiro.shimoda.uh@renesas.com; ruanjinjie@huawei.com;
u.kleine-koenig@pengutronix.de; mkl@pengutronix.de; lee@kernel.org; set_pte_at@outlook.com;
linux-arm-kernel@lists.infradead.org; netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org;
linux-rdma@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-wireless@vger.kernel.org;
brcm80211-dev-list.pdl@broadcom.com; SHA-cyfmac-dev-list@infineon.com
Subject: [PATCH -next 3/6] net/mlx4: Remove an unnecessary ternary operator

There is a ternary operator, the true or false judgement
of which is unnecessary in C language semantics.

Signed-off-by: Ruan Jinjie <redacted>
---
 drivers/net/ethernet/mellanox/mlx4/port.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c b/drivers/net/ethernet/mellanox/mlx4/port.c
index 256a06b3c096..1c289488d050 100644
--- a/drivers/net/ethernet/mellanox/mlx4/port.c
+++ b/drivers/net/ethernet/mellanox/mlx4/port.c

@@ -176,7 +176,7 @@ static bool mlx4_need_mf_bond(struct mlx4_dev *dev)
        mlx4_foreach_port(i, dev, MLX4_PORT_TYPE_ETH)
                ++num_eth_ports;

-       return (num_eth_ports ==  2) ? true : false;
+       return num_eth_ports ==  2;

It should be one space between '=' and '2'.

Thank you! I'll improve it sooner.

quoted

 }

 int __mlx4_register_mac(struct mlx4_dev *dev, u8 port, u64 mac)
--
2.34.1


------Please consider the environment before printing this e-mail.