Thread (6 messages) 6 messages, 4 authors, 2023-08-05

Re: [PATCH bpf] bpf, sockmap: Fix map type error in sock_map_del_link

From: Xu Kuohai <xukuohai@huaweicloud.com>
Date: 2023-08-01 02:24:28
Also in: bpf

On 8/1/2023 9:19 AM, Martin KaFai Lau wrote:
On 7/28/23 3:56 AM, Xu Kuohai wrote:
quoted
sock_map_del_link() operates on both SOCKMAP and SOCKHASH, although
both types have member named "progs", the offset of "progs" member in
these two types is different, so "progs" should be accessed with the
real map type.
The patch makes sense to me. Can a test be written to trigger it?
Thank you for the review. I have a messy prog that triggers memleak
caused by this issue. I'll try to simplify it to a test.
John, please review.


.
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help