Thread (4 messages) 4 messages, 3 authors, 2023-08-01

Re: [PATCH bpf] bpf, sockmap: Fix bug that strp_done cannot be called

From: Martin KaFai Lau <martin.lau@linux.dev>
Date: 2023-08-01 01:22:58
Also in: bpf

On 7/28/23 3:57 AM, Xu Kuohai wrote:
strp_done is only called when psock->progs.stream_parser is not NULL,
but stream_parser was set to NULL by sk_psock_stop_strp(), called
by sk_psock_drop() earlier. So, strp_done can never be called.

Introduce SK_PSOCK_RX_ENABLED to mark whether there is strp on psock.
Change the condition for calling strp_done from judging whether
stream_parser is set to judging whether this flag is set. This flag is
only set once when strp_init() succeeds, and will never be cleared later.
John, please help to review.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help