Re: [PATCH bpf-next] bpf, sockmap: Rename sock_map_get_from_fd to sock_map_prog_attach
From: Xu Kuohai <xukuohai@huaweicloud.com>
Date: 2023-08-31 02:24:40
Also in:
bpf, lkml
From: Xu Kuohai <xukuohai@huaweicloud.com>
Date: 2023-08-31 02:24:40
Also in:
bpf, lkml
On 8/31/2023 10:09 AM, John Fastabend wrote:
Xu Kuohai wrote:quoted
From: Xu Kuohai <redacted> What function sock_map_get_from_fd does is to attach a bpf prog to a sock map, so rename it to sock_map_prog_attach to make it more readable. Signed-off-by: Xu Kuohai <redacted> ---I don't really think the rename is needed. It will just make any backports difficult.
OK, please ignore this patch, this function has been around for a long time, maybe everyone is used to the name and I don't insist on renaming it.
.