Thread (18 messages) 18 messages, 3 authors, 2023-08-30

Re: [PATCH v3 2/4] dt-bindings: net: Add Loongson-1 Ethernet Controller

From: Krzysztof Kozlowski <hidden>
Date: 2023-08-27 07:57:16
Also in: linux-devicetree, linux-mips, lkml

On 26/08/2023 23:04, Serge Semin wrote:
quoted
+  clock-names:
+    items:
+      - const: stmmaceth
  clock-names:
    const: stmmaceth
?
The existing syntax is correct. This is a string array.
quoted
+
+  interrupts:
+    maxItems: 1
+
quoted
+  interrupt-names:
+    items:
+      - const: macirq
  interrupt-names:
    const: macirq
?
As well.
quoted
+
+  loongson,ls1-syscon:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description:
+      Phandle to the syscon containing some extra configurations
+      including PHY interface mode.
+
quoted
+  phy-mode:
+    items:
+      - enum:
+          - mii
+          - rmii
  phy-mode:
    enum: ...
?
Here indeed, this is a string, not a list, so items are wrong.



Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help