RE: [PATCH v2 2/2] selftests/net: replace ternary operator with min()/max()

From
David Laight <hidden>
Date
2023-08-25 09:33:14
Also in
linux-kernel-mentees, linux-kselftest, lkml
Reply to
Mahmoud Maatuq, 2023-08-24
From: Mahmoud Maatuq
Sent: 24 August 2023 21:24
....
quoted hunk ↗ jump to hunk
 		tdeliver = glob_tstart + ts->delay_us * 1000;
-		tdeliver_max = tdeliver_max > tdeliver ?
-			       tdeliver_max : tdeliver;
+		tdeliver_max = max(tdeliver_max, tdeliver);
That was spectacularly horrid...
What is wrong with using:
	if (tdeliver > tdeliver_max)
		tdeliver_max = tdeliver;
That is pretty obviously calculating the upper bound.
Even the version with max() needs extra parsing by the human reader.

(The only issue is whether it reads better with the if condition
reversed.)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
Thread (9 messages) 9 messages, 4 authors, last reply 2023-08-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help