Thread (8 messages) flat view 8 messages, 4 authors, 2023-08-21

Re: [PATCH 1/2] can: netlink: support setting hardware filters

From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-08-17 16:46:09
Also in: linux-can, lkml

On Thu, 17 Aug 2023 12:10:13 +0200 Martin Hundebøll wrote:
+		int len = nla_len(data[IFLA_CAN_HW_FILTER]);
+		int num_filter = len / sizeof(struct can_filter);
+		struct can_filter *filter = nla_data(data[IFLA_CAN_HW_FILTER]);
This will prevent you from ever extending struct can_filter in 
a backward-compatible fashion, right? I obviously know very little
about CAN but are you confident a more bespoke API to manipulate
filters individually and allow extensibility is not warranted?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help