Re: [PATCH] tpm_tis: Revert "tpm_tis: Disable interrupts on ThinkPad T490s"

On Tue Aug 15, 2023 at 2:13 AM EEST, Jerry Snitselaar wrote:

On Mon, Aug 14, 2023 at 07:40:53PM +0300, Jarkko Sakkinen wrote:

quoted

Since for MMIO driver using FIFO registers, also known as tpm_tis, the
default (and tbh recommended) behaviour is now the polling mode, the
"tristate" workaround is no longer for benefit.

If someone wants to explicitly enable IRQs for a TPM chip that should be
without question allowed. It could very well be a piece hardware in the
existing deny list because of e.g. firmware update or something similar.

While at it, document the module parameter, as this was not done in 2006
when it first appeared in the mainline.

Link: https://lore.kernel.org/linux-integrity/20201015214430.17937-1-jsnitsel@redhat.com/ (local)
Link: https://lore.kernel.org/all/1145393776.4829.19.camel@localhost.localdomain/ (local)
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>

I was just typing an email to say that it looks like 6aaf663ee04a ("tpm_tis: Opt-in interrupts") will require
updating tpm_tis_disable_irq(), but you are already dealing with it. :)

Reviewed-by: Jerry Snitselaar <redacted>

Thanks!

BR, Jarkko