Re: [PATCH net-next v6 1/6] page_pool: frag API support for 32-bit arch with 64-bit DMA
From: Simon Horman <horms@kernel.org>
Date: 2023-08-15 11:25:42
Also in:
linux-rdma, lkml
On Mon, Aug 14, 2023 at 08:56:38PM +0800, Yunsheng Lin wrote: ...
quoted hunk ↗ jump to hunk
diff --git a/net/core/page_pool.c b/net/core/page_pool.c index 77cb75e63aca..d62c11aaea9a 100644 --- a/net/core/page_pool.c +++ b/net/core/page_pool.c
...
quoted hunk ↗ jump to hunk
@@ -737,18 +736,16 @@ static void page_pool_free_frag(struct page_pool *pool) page_pool_return_page(pool, page); } -struct page *page_pool_alloc_frag(struct page_pool *pool, - unsigned int *offset, - unsigned int size, gfp_t gfp) +struct page *__page_pool_alloc_frag(struct page_pool *pool, + unsigned int *offset, + unsigned int size, gfp_t gfp) { unsigned int max_size = PAGE_SIZE << pool->p.order; struct page *page = pool->frag_page; - if (WARN_ON(!(pool->p.flags & PP_FLAG_PAGE_FRAG) || - size > max_size)) + if (WARN_ON(!(pool->p.flags & PP_FLAG_PAGE_FRAG))
Hi Yunsheng Lin, There is a ')' missing on the line above, which results in a build failure.
quoted hunk ↗ jump to hunk
return NULL; - size = ALIGN(size, dma_get_cache_alignment()); *offset = pool->frag_offset; if (page && *offset + size > max_size) {@@ -781,7 +778,7 @@ struct page *page_pool_alloc_frag(struct page_pool *pool, alloc_stat_inc(pool, fast); return page; } -EXPORT_SYMBOL(page_pool_alloc_frag); +EXPORT_SYMBOL(__page_pool_alloc_frag); static void page_pool_empty_ring(struct page_pool *pool) {
-- pw-bot: changes-requested