Re: [PATCH net-next] page_pool: Set page pool size.

From
Jesper Dangaard Brouer <hidden>
Date
2023-08-14 08:46:07
Also in
lkml
Reply to
Ratheesh Kannoth, 2023-08-09
On 09/08/2023 04.19, Ratheesh Kannoth wrote:
https://lore.kernel.org/netdev/
	15d32b22-22b0-64e3-a49e-88d780c24616@kernel.org/T/
For the record I like this code change better than changing page_pool
core code. I like and agree with Olek's (Alexander Lobakin) suggestion.

But the commit message need to be improved as it is too thin.
(And link is getting split in two lines for some reason)
quoted hunk ↗ jump to hunk
Suggested-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
---
  drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
index 8336cea16aff..2986e238104e 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
@@ -1434,7 +1434,8 @@ int otx2_pool_init(struct otx2_nic *pfvf, u16 pool_id,
  	}
  
  	pp_params.flags = PP_FLAG_PAGE_FRAG | PP_FLAG_DMA_MAP;
-	pp_params.pool_size = numptrs;
+#define OTX2_PAGE_POOL_SIZE 2048
+	pp_params.pool_size = OTX2_PAGE_POOL_SIZE;
  	pp_params.nid = NUMA_NO_NODE;
  	pp_params.dev = pfvf->dev;
  	pp_params.dma_dir = DMA_FROM_DEVICE;
  
Thread (3 messages) 3 messages, 2 authors, last reply 2023-08-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help