Re: [PATCH net-next v5 3/3] net: dsa: rzn1-a5psw: add vlan support
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2023-08-11 10:06:21
Also in:
linux-renesas-soc, lkml
On Thu, Aug 10, 2023 at 11:36:51AM +0200, alexis.lothore@bootlin.com wrote:
+static int a5psw_port_vlan_add(struct dsa_switch *ds, int port,
+ const struct switchdev_obj_port_vlan *vlan,
+ struct netlink_ext_ack *extack)
+{
+ dev_dbg(a5psw->dev, "Add VLAN %d on port %d, %s, %s\n",
+ vid, port, tagged ? "tagged" : "untagged",
+ pvid ? "PVID" : "no PVID");
+}
+
+static int a5psw_port_vlan_del(struct dsa_switch *ds, int port,
+ const struct switchdev_obj_port_vlan *vlan)
+{
+ dev_dbg(a5psw->dev, "Removing VLAN %d on port %d\n", vid, port);
+}These are unnecessary, we have trace points for VLANs in net/dsa/trace.h.