Re: [PATCH v9 net-next 16/23] net/tcp: Ignore specific ICMPs for TCP-AO connections
From: Dmitry Safonov <hidden>
Date: 2023-08-10 16:41:26
Also in:
lkml
On 8/10/23 17:36, Eric Dumazet wrote:
On Thu, Aug 10, 2023 at 6:27 PM Dmitry Safonov [off-list ref] wrote:quoted
On 8/8/23 14:43, Eric Dumazet wrote:quoted
On Wed, Aug 2, 2023 at 7:27 PM Dmitry Safonov [off-list ref] wrote:[..]quoted
quoted
+bool tcp_ao_ignore_icmp(struct sock *sk, int type, int code)const struct sock *sk ?Well, I can't really: atomic64_inc(&ao->counters.dropped_icmp)I think we could, because this would still work. struct tcp_ao_info *ao; // This is rw object
Yeah, right, had not enough coffee today.
ao = rcu_dereference(tcp_sk(sk)->ao_info); This helper looks to accept unlocked sockets, so marking them const would avoid mistakes in the future.
I see, will make it `const', thanks!
--
Dmitry