Re: [PATCH RESEND net-next 2/2] dt-bindings: net: dsa: mediatek,mt7530: document MDIO-bus
From: Arınç ÜNAL <hidden>
Date: 2023-08-09 09:03:38
Also in:
linux-arm-kernel, linux-devicetree, linux-mediatek, lkml
Subsystem:
networking drivers, networking [dsa], open firmware and flattened device tree bindings, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Andrew Lunn, Vladimir Oltean, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Torvalds
On 8.08.2023 15:17, Vladimir Oltean wrote:
On Sat, Aug 05, 2023 at 11:15:15PM +0300, Arınç ÜNAL wrote:quoted
I don't see a reason to resubmit this without addressing the requested change.quoted
quoted
Wouldn't we just skip the whole issue by documenting the need for defining all PHYs used on the switch when defining the MDIO bus?Good idea, please do that.https://lore.kernel.org/netdev/0f501bb6-18a0-1713-b08c-6ad244c022ec@arinc9.com/ (local) ArınçArınç, where do you see that comment being added? AFAIU, it is a characteristic of the generic __of_mdiobus_register() code to set mdio->phy_mask = ~0, and nothing specific to the mt7530.
What I believe is specific to DSA is, 1:1 mapping of the port reg to the PHY reg on the mdio bus is disabled if the mdio bus is defined. Therefore, I believe a notice like below fits mediatek,mt7530.yaml.
diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
index e532c6b795f4..c59d58252cd5 100644
--- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml@@ -128,6 +128,15 @@ properties: See Documentation/devicetree/bindings/regulator/mt6323-regulator.txt for details for the regulator setup on these boards. + mdio: + $ref: /schemas/net/mdio.yaml# + unevaluatedProperties: false + description: + Node for the internal MDIO bus connected to the embedded ethernet-PHYs. + For every port defined under the "^(ethernet-)?ports$" node, a PHY must be + defined under here and a phy-handle property must be defined under the + port node to point to the PHY node. + mediatek,mcm: type: boolean description:
Arınç