Re: [RFC PATCH v2 net-next 5/6] net/smc: support max links per lgr negotiation in clc handshake
From: Simon Horman <horms@kernel.org>
Date: 2023-08-07 15:09:59
Also in:
linux-s390, lkml
On Mon, Aug 07, 2023 at 02:27:19PM +0800, Guangguan Wang wrote: ...
quoted hunk ↗ jump to hunk
diff --git a/net/smc/smc_llc.c b/net/smc/smc_llc.c
...
quoted hunk ↗ jump to hunk
@@ -1414,6 +1420,9 @@ int smc_llc_srv_add_link(struct smc_link *link, goto out; } + if (lgr->type == SMC_LGR_SINGLE && lgr->max_links <= 1)
Hi Guangguan Wang, The function will return rc. Should it be set to an error value here? Flagged by Smatch.
+ goto out;
+
/* ignore client add link recommendation, start new flow */
ini->vlan_id = lgr->vlan_id;
if (lgr->smc_version == SMC_V2) {
--
2.24.3 (Apple Git-128)