RE: Re: [PATCH net] octeontx2-pf: Set maximum queue size to 16K

From
Ratheesh Kannoth <rkannoth@marvell.com>
Date
2023-08-03 02:08:37
Also in
lkml
Reply to
Alexander Lobakin, 2023-08-02
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Sent: Wednesday, August 2, 2023 9:42 PM
To: Ratheesh Kannoth <rkannoth@marvell.com>
Subject: [EXT] Re: [PATCH net] octeontx2-pf: Set maximum queue size to 16K
+ring->rx_max_pending = 16384; /* Page pool support on RX */

This is very hardcodish. Why not limit the Page Pool size when creating
instead? It's perfectly fine to have a queue with 64k descriptors and a Page
Pool with only ("only" :D) 16k elements.
Page Pool size affects only the size of the embedded ptr_ring, which is used
for indirect (locking) recycling. I would even recommend to not go past 2k for
PP sizes, it makes no sense and only consumes memory.
These recycling will impact on performance, right ? else, why didn't page pool made this size as constant. 

Thread (9 messages) 9 messages, 3 authors, last reply 2023-08-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help