Thread (26 messages) flat view 26 messages, 5 authors, 2023-08-09

RE: [PATCH V3 net-next] net: fec: add XDP_TX feature support

From: Wei Fang <wei.fang@nxp.com>
Date: 2023-08-02 02:43:23
Also in: bpf, lkml

-----Original Message-----
Subject: Re: [PATCH V3 net-next] net: fec: add XDP_TX feature support

On Mon, 31 Jul 2023 14:00:25 +0800 Wei Fang wrote:
quoted
 	case XDP_TX:
+		err = fec_enet_xdp_tx_xmit(fep->netdev, xdp);
+		if (err) {
+			ret = FEC_ENET_XDP_CONSUMED;
+			page = virt_to_head_page(xdp->data);
+			page_pool_put_page(rxq->page_pool, page, sync, true);
The error path should call trace_xdp_exception().
Thanks for your reminder, it made me realize that the error processing of
other XDP actions also needs to add exception tracing. I'll add the exception
tracing for XDP_TX in V4 patch, and add the tracing for other XDP actions in
a separate patch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help