-----Original Message-----
From: Simon Horman <horms@kernel.org>
Sent: Tuesday, August 1, 2023 9:01 PM
To: Souradeep Chakrabarti <redacted>
Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
[off-list ref]; wei.liu@kernel.org; Dexuan Cui
[off-list ref]; davem@davemloft.net; edumazet@google.com;
kuba@kernel.org; pabeni@redhat.com; Long Li [off-list ref]; Ajay
Sharma [off-list ref]; leon@kernel.org;
cai.huoqing@linux.dev; ssengar@linux.microsoft.com; vkuznets
[off-list ref]; tglx@linutronix.de; linux-hyperv@vger.kernel.org;
netdev@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
rdma@vger.kernel.org; Souradeep Chakrabarti
[off-list ref]; stable@vger.kernel.org
Subject: [EXTERNAL] Re: [PATCH V7 net] net: mana: Fix MANA VF unload when
hardware is

On Tue, Aug 01, 2023 at 05:29:13AM -0700, Souradeep Chakrabarti wrote:

...

Hi Souradeep,

quoted

+	for (i = 0; i < apc->num_queues; i++) {
+		txq = &apc->tx_qp[i].txq;
+		while (skb = skb_dequeue(&txq->pending_skbs)) {

W=1 builds with both clang-16 and gcc-12 complain that they would like an
extra set of parentheses around an assignment used as a truth value.

Thanks for letting me know. I will fix it in next version.

quoted

+			mana_unmap_skb(skb, apc);
+			dev_consume_skb_any(skb);
+		}
+		atomic_set(&txq->pending_sends, 0);
+	}
 	/* We're 100% sure the queues can no longer be woken up, because
 	 * we're sure now mana_poll_tx_cq() can't be running.
 	 */
--
2.34.1