Thread (4 messages) 4 messages, 4 authors, 2023-08-31

Re: [PATCH net] net: fib: avoid warn splat in flow dissector

From: patchwork-bot+netdevbpf@kernel.org
Date: 2023-08-31 11:40:22

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni [off-list ref]:

On Wed, 30 Aug 2023 13:00:37 +0200 you wrote:
New skbs allocated via nf_send_reset() have skb->dev == NULL.

fib*_rules_early_flow_dissect helpers already have a 'struct net'
argument but its not passed down to the flow dissector core, which
will then WARN as it can't derive a net namespace to use:

 WARNING: CPU: 0 PID: 0 at net/core/flow_dissector.c:1016 __skb_flow_dissect+0xa91/0x1cd0
 [..]
  ip_route_me_harder+0x143/0x330
  nf_send_reset+0x17c/0x2d0 [nf_reject_ipv4]
  nft_reject_inet_eval+0xa9/0xf2 [nft_reject_inet]
  nft_do_chain+0x198/0x5d0 [nf_tables]
  nft_do_chain_inet+0xa4/0x110 [nf_tables]
  nf_hook_slow+0x41/0xc0
  ip_local_deliver+0xce/0x110
  ..

[...]
Here is the summary with links:
  - [net] net: fib: avoid warn splat in flow dissector
    https://git.kernel.org/netdev/net/c/8aae7625ff3f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help