Re: [PATCH iproute2-next 1/1] tc: fix typo in netem's usage string
From: François Michel <hidden>
Date: 2023-08-31 09:12:20
From: François Michel <hidden>
Date: 2023-08-31 09:12:20
Hi, Le 31/08/23 à 11:05, Donald Hunter a écrit :
Petr Machata [off-list ref] writes:quoted
francois.michel@uclouvain.be writes:quoted
From: François Michel <redacted> Signed-off-by: François Michel <redacted>Reviewed-by: Petr Machata <petrm@nvidia.com> That said...quoted
" [ loss state P13 [P31 [P32 [P23 P14]]]\n" " [ loss gemodel PERCENT [R [1-H [1-K]]]\n"... and sorry for piling on like this, but since we are in the domain of fixing netem typos, if you would also fix the missing brackets on these two lines, that would be awesome.The tc-netem(8) man page suggests (and usage confirms) that P14 is also an optional parameter so it should be bracketed as well.
Allright. While we're at it, I'll will also probably unify the spaces around brackets. On other qdiscs, brackets seem to be systematically surrounded by spaces. François
https://www.man7.org/linux/man-pages/man8/tc-netem.8.html