Re: [PATCH net-next v3 2/3] net: bcmgenet: Return PTR_ERR() for fixed_phy_register()
From: Doug Berger <opendmb@gmail.com>
Date: 2023-08-19 00:27:54
On 8/18/2023 12:07 AM, Ruan Jinjie wrote:
fixed_phy_register() returns -EPROBE_DEFER, -EINVAL and -EBUSY, etc, in addition to -ENODEV. The Best practice is to return these error codes with PTR_ERR(). Signed-off-by: Ruan Jinjie <redacted> --- v3: - Split the return value check into another patch set. - Update the commit title and message. --- drivers/net/ethernet/broadcom/genet/bcmmii.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Doug Berger <opendmb@gmail.com>