Thread (29 messages) flat view 29 messages, 5 authors, 2023-08-18

Re: [RFC net-next 01/13] net: page_pool: split the page_pool_params into fast and slow

From: Jesper Dangaard Brouer <hawk@kernel.org>
Date: 2023-08-17 09:31:32


On 17/08/2023 01.42, Jakub Kicinski wrote:
struct page_pool is rather performance critical and we use
16B of the first cache line to store 2 pointers used only
by test code. Future patches will add more informational
(non-fast path) attributes.

It's convenient for the user of the API to not have to worry
which fields are fast and which are slow path. Use struct
groups to split the params into the two categories internally.

Signed-off-by: Jakub Kicinski<kuba@kernel.org>
---
  include/net/page_pool/types.h | 31 +++++++++++++++++++------------
  net/core/page_pool.c          |  7 ++++---
  2 files changed, 23 insertions(+), 15 deletions(-)
With changes in 2/13 where you add a bool to avoid accessing "slow":

Acked-by: Jesper Dangaard Brouer <hawk@kernel.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help