Re: [PATCH net-next v3 10/10] ethtool: netlink: always pass genl_info to .prepare_data
From: Jiri Pirko <jiri@resnulli.us>
Date: 2023-08-15 06:07:11
From: Jiri Pirko <jiri@resnulli.us>
Date: 2023-08-15 06:07:11
Mon, Aug 14, 2023 at 11:47:23PM CEST, kuba@kernel.org wrote:
We had a number of bugs in the past because developers forgot to fully test dumps, which pass NULL as info to .prepare_data. .prepare_data implementations would try to access info->extack leading to a null-deref. Now that dumps and notifications can access struct genl_info we can pass it in, and remove the info null checks. Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com> Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com> # pause Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jiri Pirko <redacted>