Re: [patch net-next v3 10/13] devlink: allow user to narrow per-instance dumps by passing handle attrs
From: Jiri Pirko <jiri@resnulli.us>
Date: 2023-08-11 08:41:10
Fri, Aug 11, 2023 at 04:17:22AM CEST, kuba@kernel.org wrote:
On Thu, 10 Aug 2023 15:15:36 +0200 Jiri Pirko wrote:quoted
+ struct nlattr **attrs = info->attrs; + int flags = NLM_F_MULTI; + + if (attrs) + flags |= NLM_F_DUMP_FILTERED;Are attrs NULL if user passed no TLVs?
True, I fixed this for v4.
TBH I'm not sure how valuable NLM_F_DUMP_FILTERED is in the first place.
Yeah, I just noticed this flag, so I decided to throw it in. I don't see any harm in that. And I believe it is actually correct to use this flag.