Re: [PATCH net-next] net: omit ndo_hwtstamp_get() call when possible in dev_set_hwtstamp_phylib()
From: patchwork-bot+netdevbpf@kernel.org
Date: 2023-08-06 12:30:21
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller [off-list ref]: On Fri, 4 Aug 2023 16:49:39 +0300 you wrote:
Setting dev->priv_flags & IFF_SEE_ALL_HWTSTAMP_REQUESTS is only legal for drivers which were converted to ndo_hwtstamp_get() and ndo_hwtstamp_set(), and it is only there that we call ndo_hwtstamp_set() for a request that otherwise goes to phylib (for stuff like packet traps, which need to be undone if phylib failed, hence the old_cfg logic). The problem is that we end up calling ndo_hwtstamp_get() when we don't need to (even if the SIOCSHWTSTAMP wasn't intended for phylib, or if it was, but the driver didn't set IFF_SEE_ALL_HWTSTAMP_REQUESTS). For those unnecessary conditions, we share a code path with virtual drivers (vlan, macvlan, bonding) where ndo_hwtstamp_get() is implemented as generic_hwtstamp_get_lower(), and may be resolved through generic_hwtstamp_ioctl_lower() if the lower device is unconverted. [...]
Here is the summary with links:
- [net-next] net: omit ndo_hwtstamp_get() call when possible in dev_set_hwtstamp_phylib()
https://git.kernel.org/netdev/net-next/c/c35e927cbe09
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html