Re: [PATCH net] vxlan: Fix nexthop hash size
From: patchwork-bot+netdevbpf@kernel.org
Date: 2023-08-02 10:00:22
Hello: This patch was applied to netdev/net.git (main) by David S. Miller [off-list ref]: On Mon, 31 Jul 2023 16:02:08 -0400 you wrote:
The nexthop code expects a 31 bit hash, such as what is returned by
fib_multipath_hash() and rt6_multipath_hash(). Passing the 32 bit hash
returned by skb_get_hash() can lead to problems related to the fact that
'int hash' is a negative number when the MSB is set.
In the case of hash threshold nexthop groups, nexthop_select_path_hthr()
will disproportionately select the first nexthop group entry. In the case
of resilient nexthop groups, nexthop_select_path_res() may do an out of
bounds access in nh_buckets[], for example:
hash = -912054133
num_nh_buckets = 2
bucket_index = 65535
[...]
Here is the summary with links:
- [net] vxlan: Fix nexthop hash size
https://git.kernel.org/netdev/net/c/0756384fb1bd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html