Thread (35 messages) 35 messages, 4 authors, 2023-08-02

Re: [patch net-next v2 08/11] devlink: introduce set of macros and use it for split ops definitions

From: Jiri Pirko <jiri@resnulli.us>
Date: 2023-08-01 06:41:18

Mon, Jul 31, 2023 at 06:57:45PM CEST, kuba@kernel.org wrote:
On Mon, 31 Jul 2023 14:21:52 +0200 Jiri Pirko wrote:
quoted
quoted
If you want to use split ops extensively please use the nlspec
and generate the table automatically. Integrating closer with
the spec will have many benefits.  
Yeah, I was thinging about it, it just didn't seem necessary. Okay, will
check that out.

Btw, does that mean that any split-ops usage would require generated
code? If yes, could you please document that somewhere, probably near
the struct?
I wrote it somewhere, probably the commit messages for the split ops.
I believe we need to have it written down in actual codebase.

The tools are not 100% ready for partial generation I don't want to
force everyone to do code gen. But the homegrown macros in every family
are a no go.
So you say that if I spell it out without macros, that would be okay?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help