Re: [RESEND PATCH v2] selftests:connector: Fix input argument error paths to skip
From: Shuah Khan <skhan@linuxfoundation.org>
Date: 2023-07-31 20:23:50
Also in:
linux-kselftest, lkml
From: Shuah Khan <skhan@linuxfoundation.org>
Date: 2023-07-31 20:23:50
Also in:
linux-kselftest, lkml
On 7/28/23 18:24, Shuah Khan wrote:
Fix input argument parsing paths to skip from their error legs. This fix helps to avoid false test failure reports without running the test. Signed-off-by: Shuah Khan <skhan@linuxfoundation.org> --- v2: Removed root check based on Anjali's review comments. Add netdev to RESEND tools/testing/selftests/connector/proc_filter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/tools/testing/selftests/connector/proc_filter.c b/tools/testing/selftests/connector/proc_filter.c index 4fe8c6763fd8..4a825b997666 100644 --- a/tools/testing/selftests/connector/proc_filter.c +++ b/tools/testing/selftests/connector/proc_filter.c@@ -248,7 +248,7 @@ int main(int argc, char *argv[]) if (argc > 2) { printf("Expected 0(assume no-filter) or 1 argument(-f)\n"); - exit(1); + exit(KSFT_SKIP); } if (argc == 2) {@@ -256,7 +256,7 @@ int main(int argc, char *argv[]) filter = 1; } else { printf("Valid option : -f (for filter feature)\n"); - exit(1); + exit(KSFT_SKIP); } }
Hi Jakub, I sent v2 for patch 3 in the series. Do you want me to send the entire series again with this revised 3rd patch. thanks, -- Shuah