Thread (18 messages) 18 messages, 6 authors, 2023-08-01

Re: [PATCH 2/4] soc: qcom: aoss: Add debugfs interface for sending messages

From: Bjorn Andersson <hidden>
Date: 2023-07-31 16:01:24
Also in: linux-arm-msm, linux-remoteproc, lkml

On Mon, Jul 31, 2023 at 10:15:34AM +0200, Konrad Dybcio wrote:
On 31.07.2023 06:10, Bjorn Andersson wrote:
quoted
From: Chris Lew <redacted>
No QUIC email?
That's the author and s-o-b address of the patch. mailmap will help you
if you want to reach him.
[...]

quoted
+static ssize_t qmp_debugfs_write(struct file *file, const char __user *userstr,
+				 size_t len, loff_t *pos)
+{
+	struct qmp *qmp = file->private_data;
+	char buf[QMP_MSG_LEN];
+	int ret;
+
+	if (!len || len > QMP_MSG_LEN)
=? Otherwise the last char may be overwritten by the NULL termination
couple lines below
My mind had a '\0' accounted for in len as well, but you're right.

Thanks,
Bjorn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help