Thread (5 messages) 5 messages, 4 authors, 2023-07-14

Re: [PATCH v2 net] gso: fix dodgy bit handling for GSO_UDP_L4

From: Yan Zhai <hidden>
Date: 2023-07-14 04:28:13
Also in: linux-sctp, lkml

On Thu, Jul 13, 2023 at 12:38 PM Willem de Bruijn
[off-list ref] wrote:
On Thu, Jul 13, 2023 at 1:28 PM Yan Zhai [off-list ref] wrote:
quoted
Commit 1fd54773c267 ("udp: allow header check for dodgy GSO_UDP_L4
packets.") checks DODGY bit for UDP, but for packets that can be fed
directly to the device after gso_segs reset, it actually falls through
to fragmentation:

https://lore.kernel.org/all/CAJPywTKDdjtwkLVUW6LRA2FU912qcDmQOQGt2WaDo28KzYDg+A@mail.gmail.com/ (local)

This change restores the expected behavior of GSO_UDP_L4 packets.

Fixes: 1fd54773c267 ("udp: allow header check for dodgy GSO_UDP_L4 packets.")
Suggested-by: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Signed-off-by: Yan Zhai <redacted>
Reviewed-by: Willem de Bruijn <willemb@google.com>

for next time: places hyperlinks in the block of tags at the bottom of
the commit as "Link: ${URL}"
Good to learn, thanks!
--
Yan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help