On Tue, Jul 11, 2023 at 02:01:13PM +0300, Andy Shevchenko wrote:

On Mon, Jul 10, 2023 at 06:30:32PM +0100, Mark Brown wrote:

quoted

On Mon, Jul 10, 2023 at 06:49:21PM +0300, Andy Shevchenko wrote:

quoted

quoted

+ * Assume speed to be 100 kHz if it's not defined at the time of invocation.

quoted

You didn't mention this bit in the changelog, and I'm not 100% convinced
it was the best idea in the first place.  It's going to result in some
very big timeouts if it goes off, and we really should be doing
validation much earlier in the process.

Okay, let's drop this change.

Like I say we *should* be fine with the refactoring without this, or at
least if it's an issue we should improve the validation.

quoted

quoted

+	u32 speed_hz = xfer->speed_hz ?: 100000;

quoted

Not only the ternery operator, but the version without the second
argument for extra clarity!

Elvis can be interpreted as "A _or_ B (if A is false/0)".
Some pieces related to SPI use Elvis already IIRC.

I understand what it means, I just don't find it's adding clarity most
of the times it's used (there's a few places where it is useful like
pasting in strings in formats).  There are some examples that I'd
complain about in the code, most of them predating me working on SPI too
much, but I'm not a fan.