Re: [PATCH net 1/2] net: dsa: tag_sja1105: fix MAC DA patching from meta frames
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2023-07-02 14:37:43
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2023-06-30 · Re: [PATCH net 1/2] net: dsa: tag_sja1105: fix MAC DA patching from meta frames · Simon Horman <hidden>
On 6/29/2023 4:14 PM, Vladimir Oltean wrote:
The SJA1105 manual says that at offset 4 into the meta frame payload we
have "MAC destination byte 2" and at offset 5 we have "MAC destination
byte 1". These are counted from the LSB, so byte 1 is h_dest[ETH_HLEN-2]
aka h_dest[4] and byte 2 is h_dest[ETH_HLEN-3] aka h_dest[3].
The sja1105_meta_unpack() function decodes these the other way around,
so a frame with MAC DA 01:80:c2:11:22:33 is received by the network
stack as having 01:80:c2:22:11:33.
Fixes: e53e18a6fe4d ("net: dsa: sja1105: Receive and decode meta frames")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> -- Florian