Thread (9 messages) 9 messages, 3 authors, 2023-07-28

Re: [PATCH net-next 1/5] nf_conntrack: fix -Wunused-const-variable=

From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-07-28 03:28:13
Also in: netfilter-devel

On Thu, 27 Jul 2023 15:35:56 +0200 Florian Westphal wrote:
When building with W=1, the following warning occurs.

net/netfilter/nf_conntrack_proto_dccp.c:72:27: warning: ‘dccp_state_names’ defined but not used [-Wunused-const-variable=]
 static const char * const dccp_state_names[] = {

We include dccp_state_names in the macro
CONFIG_NF_CONNTRACK_PROCFS, since it is only used in the place
which is included in the macro CONFIG_NF_CONNTRACK_PROCFS.
FTR I can't say I see this with the versions of gcc / clang I have :S
Fixes: 2bc780499aa3 ("[NETFILTER]: nf_conntrack: add DCCP protocol support")
Nor that it's worth a Fixes tag?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help