On Thu, Jul 27, 2023 at 12:29 PM Michael Chan [off-list ref] wrote:

On Thu, Jul 27, 2023 at 12:05 PM Jakub Kicinski [off-list ref] wrote:

quoted

I see...

Do you prefer adding a return value to tx_int() to tell
__bnxt_poll_work_done() whether the work has been done;
or to clear tx_pkts in the handler itself rather than
the caller?

It's a bigger problem.  When we transmit packets, we store these
packet buffers and advance the producer index.  The completion ring
tells us how many TX packets have completed.  We then walk the TX ring
for the number of TX packets completed and free the buffers.  If we
cannot free the buffers now, we have to save this information (the
consumer index).  We won't get this information again in the
completion ring.

I reread your comments again.  Yes, if we don't clear bnapi->tx_pkts
if we do nothing, it should work.  Since we always free all the
packets or none, it might be easier to clear it in the tx_int handler.