Re: Stacks leading into skb:kfree_skb

From
Ivan Babrou <hidden>
Date
2023-07-18 22:33:34
Reply to
David Ahern, 2023-07-15
On Fri, Jul 14, 2023 at 5:54 PM David Ahern [off-list ref] wrote:
On 7/14/23 4:13 PM, Ivan Babrou wrote:
quoted
As requested by Jakub Kicinski and David Ahern here:

* https://lore.kernel.org/netdev/20230713201427.2c50fc7b@kernel.org/ (local)

I made some aggregations for the stacks we see leading into
skb:kfree_skb endpoint. There's a lot of data that is not easily
digestible, so I lightly massaged the data and added flamegraphs in
addition to raw stack counts. Here's the gist link:

* https://gist.github.com/bobrik/0e57671c732d9b13ac49fed85a2b2290
I see a lot of packet_rcv as the tip before kfree_skb. How many packet
sockets do you have running on that box? Can you accumulate the total
packet_rcv -> kfree_skb_reasons into 1 count -- regardless of remaining
stacktrace?
Yan will respond regarding the packet sockets later in the day, he
knows this stuff better than I do.

In the meantime, here are the aggregations you requested:

* Normal: https://gist.githubusercontent.com/bobrik/0e57671c732d9b13ac49fed85a2b2290/raw/ae8aa1bc3b22fad6cf541afeb51aa8049d122d02/flamegraph.normal.packet_rcv.aggregated.svg
* Spike: https://gist.githubusercontent.com/bobrik/0e57671c732d9b13ac49fed85a2b2290/raw/ae8aa1bc3b22fad6cf541afeb51aa8049d122d02/flamegraph.spike.packet_rcv.aggregated.svg

I just realized that Github links make flamegraphs non-interactive. If
you download them and open a local copy, they should work better:

* Expand to your screen width
* Working search with highlights
* Tooltips with counts and percentages
* Working zoom
Thread (9 messages) 9 messages, 6 authors, last reply 2023-07-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help