Re: [PATCH] net: delete "<< 1U" cargo-culting
From: Paolo Abeni <pabeni@redhat.com>
Date: 2023-07-18 10:47:57
From: Paolo Abeni <pabeni@redhat.com>
Date: 2023-07-18 10:47:57
On Sat, 2023-07-15 at 13:19 +0300, Alexey Dobriyan wrote:
6.5.7 §3 "Bitwise shift operators" clearly states that
The type of the result is that of the promoted left operand
All those integer constant suffixes in the right operand are pointless,
delete them.Indeed. Still this patch is quite invasive and the net benefit looks quite marginal - if any at all. Older compiler could adhere to the standard less strictly or macro expansion - when the left '<<' operand is a macro argument - could be tricky. I think we are better of not applying this. Cheers, Paolo