Re: [PATCH v11 08/12] landlock: Add network rules and TCP hooks support
From: Konstantin Meskhidze (A) <hidden>
Date: 2023-07-03 12:39:44
Also in:
linux-security-module, netfilter-devel
From: Konstantin Meskhidze (A) <hidden>
Date: 2023-07-03 12:39:44
Also in:
linux-security-module, netfilter-devel
6/27/2023 10:48 PM, Günther Noack пишет:
On Tue, May 16, 2023 at 12:13:35AM +0800, Konstantin Meskhidze wrote:quoted
+static int add_rule_net_service(struct landlock_ruleset *ruleset, + const void __user *const rule_attr) +{ +#if IS_ENABLED(CONFIG_INET) + struct landlock_net_service_attr net_service_attr; + int res; + access_mask_t mask; + + /* Copies raw user space buffer, only one type for now. */Nit, which I came across by accident: I believe the remark "only one type for now" referred to the fact that path_beneath_attr was the only rule type up until now - but that is not true any more. Please adapt the wording also in add_rule_path_beneath, where the same comment exists.
Thanks. I will fix it.
–Günther .