Re: [RESEND][PATCH] net: cpsw: fix obtaining mac address for am3517
From: Måns Rullgård <hidden>
Date: 2023-06-24 14:24:57
Also in:
linux-omap, lkml
Possibly related (same subject, not in this thread)
- 2023-06-30 · Re: [RESEND][PATCH] net: cpsw: fix obtaining mac address for am3517 · Tony Lindgren <tony@atomide.com>
- 2023-06-24 · Re: [RESEND][PATCH] net: cpsw: fix obtaining mac address for am3517 · Måns Rullgård <hidden>
- 2023-06-24 · Re: [RESEND][PATCH] net: cpsw: fix obtaining mac address for am3517 · Andrew Lunn <andrew@lunn.ch>
- 2023-06-24 · [RESEND][PATCH] net: cpsw: fix obtaining mac address for am3517 · Mans Rullgard <hidden>
Andrew Lunn [off-list ref] writes:
On Sat, Jun 24, 2023 at 01:10:59PM +0100, Mans Rullgard wrote:quoted
From: Jeroen Hofstee <redacted> Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac id to common file") did not only move the code for an am3517, it also added the slave parameter, resulting in an invalid (all zero) mac address being returned for an am3517, since it only has a single emacHi Mans If there is only a single emac, why is the function being called with slave=1? Given the description, it seems like you are fixing the wrong problem.
See previous discussion: https://lore.kernel.org/lkml/d8ad5cab-5183-cddf-fa9a-4e7b9b8c9377@victronenergy.com/ (local) -- Måns Rullgård