Re: [PATCH net-next v4 03/15] ceph: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage

From
David Howells <dhowells@redhat.com>
Date
2023-06-23 19:44:46
Also in
ceph-devel, linux-mm, lkml
Reply to
Jakub Kicinski, 2023-06-23
Jakub Kicinski [off-list ref] wrote:
quoted
 		if (length == cursor->total_resid)
-			more = MSG_MORE;
-		ret = ceph_tcp_sendpage(con->sock, page, page_offset, length,
-					more);
+			msghdr.msg_flags |= MSG_MORE;
Should the condition also be flipped here, like you did below?
(can be a follow up if so)
Yeah - the "==" in the if-statement needs flipping to "!=".  I can send a
follow-up patch for it or respin if you prefer.

David
Thread (20 messages) 20 messages, 3 authors, last reply 2023-06-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help