Re: [PATCH v7 04/22] net/tcp: Prevent TCP-MD5 with TCP-AO being set
From: David Ahern <dsahern@kernel.org>
Date: 2023-06-18 17:50:57
Also in:
lkml
From: David Ahern <dsahern@kernel.org>
Date: 2023-06-18 17:50:57
Also in:
lkml
On 6/14/23 4:09 PM, Dmitry Safonov wrote:
Be as conservative as possible: if there is TCP-MD5 key for a given peer regardless of L3 interface - don't allow setting TCP-AO key for the same peer. According to RFC5925, TCP-AO is supposed to replace TCP-MD5 and there can't be any switch between both on any connected tuple. Later it can be relaxed, if there's a use, but in the beginning restrict any intersection. Note: it's still should be possible to set both TCP-MD5 and TCP-AO keys on a listening socket for *different* peers.
Does the testsuite cover use of both MD5 and AO for a single listening socket with different peers and then other tests covering attempts to use both for a same peer?