Re: [PATCH v2 2/2] NFC: nxp-nci: Add pad supply voltage pvdd-supply

From
Raymond Hackley <hidden>
Date
2023-06-09 20:52:59
Also in
linux-devicetree, lkml
Reply to
Mark Brown, 2023-06-09
Hi Mark,

On Friday, June 9th, 2023 at 7:34 PM, Mark Brown [off-list ref] wrote:
 
Specifically your driver should only ever call regulator_disable() to
balance out regulator_enable() calls it made itself and it should know
how many of those it has done. regulator_is_enabled() should only ever
be used during probe if for some reason it is important to figure out if
the device is already powered for startup, this should be very unusual.
If something else enabled the regualtor then whatever did that needs to
undo those enables, not another driver.
Thnak you for explanation. I should drop regulator_is_enabled() here since
it's misused.

Regards,
Raymond
Thread (9 messages) 9 messages, 3 authors, last reply 2023-06-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help