-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Wednesday, June 7, 2023 4:38 PM
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: linux-hyperv@vger.kernel.org; netdev@vger.kernel.org; Dexuan Cui
[off-list ref]; KY Srinivasan [off-list ref]; Paul Rosswurm
[off-list ref]; olaf@aepfle.de; vkuznets@redhat.com;
davem@davemloft.net; wei.liu@kernel.org; edumazet@google.com;
pabeni@redhat.com; leon@kernel.org; Long Li [off-list ref];
ssengar@linux.microsoft.com; linux-rdma@vger.kernel.org;
daniel@iogearbox.net; john.fastabend@gmail.com; bpf@vger.kernel.org;
ast@kernel.org; Ajay Sharma [off-list ref];
hawk@kernel.org; tglx@linutronix.de; shradhagupta@linux.microsoft.com;
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next,V2] net: mana: Add support for vlan tagging

On Wed,  7 Jun 2023 13:34:02 -0700 Haiyang Zhang wrote:

quoted

To support vlan, use MANA_LONG_PKT_FMT if vlan tag is present in TX
skb. Then extract the vlan tag from the skb struct, and save it to
tx_oob for the NIC to transmit. For vlan tags on the payload, they
are accepted by the NIC too.

For RX, extract the vlan tag from CQE and put it into skb.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
---
V2:
Removed the code that extracts inband tag, because our NIC accepts
inband tags too.

Please don't rush multiple versions, if your previous version is buggy
you have to reply to it saying so and then wait before posting v2.

Will do. Thanks.