Re: [PATCH v3 0/1] gro: decrease size of CB
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Date: 2023-06-06 13:26:37
Also in:
lkml
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Date: 2023-06-06 13:26:37
Also in:
lkml
From: Richard Gobert <redacted> Date: Mon, 5 Jun 2023 15:58:23 +0200
quoted
I hope you've checked that there's no difference in object code with and w/o `inline`? Sometimes the compilers do weird things and stop inlining oneliners if they're used more than once. skb_gro_reset_offset() is marked `inline` exactly due to that =\Checked on standard x86-64 and arm64 gcc compilers. Would you check any other cases?
I'd say it's enough, so no problem. Sometimes some odd things happen, but you can never predict all of them. I can't give Reviewed-by now that it has been already applied :D Had a long weekend and all that. But the change is really good. Thanks, Olek