Thread (62 messages) 62 messages, 9 authors, 2023-06-16

Re: [PATCH 17/21] power: reset: at91-poweroff: lookup for proper pmc dt node for sam9x7

From: Krzysztof Kozlowski <hidden>
Date: 2023-06-05 13:33:21
Also in: linux-arm-kernel, linux-clk, linux-devicetree, linux-pm, linux-usb, lkml

On 05/06/2023 15:04, Nicolas Ferre wrote:
On 05/06/2023 at 08:43, Krzysztof Kozlowski wrote:
quoted
On 03/06/2023 22:02, Varshini Rajendran wrote:
quoted
Use sam9x7 pmc's compatible to lookup for in the SHDWC driver

Signed-off-by: Varshini Rajendran <redacted>
---
  drivers/power/reset/at91-sama5d2_shdwc.c | 1 +
  1 file changed, 1 insertion(+)
diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c
index d8ecffe72f16..d0f29b99f25e 100644
--- a/drivers/power/reset/at91-sama5d2_shdwc.c
+++ b/drivers/power/reset/at91-sama5d2_shdwc.c
@@ -326,6 +326,7 @@ static const struct of_device_id at91_pmc_ids[] = {
       { .compatible = "atmel,sama5d2-pmc" },
       { .compatible = "microchip,sam9x60-pmc" },
       { .compatible = "microchip,sama7g5-pmc" },
+     { .compatible = "microchip,sam9x7-pmc" },
Why do you need new entry if these are compatible?
Yes, PMC is very specific to a SoC silicon. As we must look for it in 
the shutdown controller, I think we need a new entry here.
??? How does it answer to my question at all? What is exactly specific
which warrants new entry?


Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help