Thread (13 messages) 13 messages, 4 authors, 2023-06-06

Re: [PATCH net-next v4 2/4] net: ethernet: altera-tse: Convert to mdio-regmap and use PCS Lynx

From: Maxime Chevallier <maxime.chevallier@bootlin.com>
Date: 2023-06-05 13:15:26
Also in: linux-arm-kernel, lkml

Hi,

On Thu,  1 Jun 2023 16:14:52 +0200
Maxime Chevallier [off-list ref] wrote:
The newly introduced regmap-based MDIO driver allows for an easy mapping
of an mdiodevice onto the memory-mapped TSE PCS, which is actually a
Lynx PCS.

Convert Altera TSE to use this PCS instead of the pcs-altera-tse, which
is nothing more than a memory-mapped Lynx PCS.

Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
[ ... ]
-	ret = request_and_map(pdev, "pcs", &pcs_res,
-			      &priv->pcs_base);
+	ret = request_and_map(pdev, "pcs", &pcs_res, &priv->pcs_base);
It turns out I'm missing the zeroing of pcs_regmap_cfg, which can trigger
errors at probe time. I know this series has been applied, and that I can
send a followup fix, but due to the missing regmap patch in the net-next
tree, this series will break altera_tse and dwmac_socfpga anyway,as
mentionned here (and in the cover):

https://lore.kernel.org/netdev/20230605142039.3f8d1530@pc-7.home/ (local)

Is reverting the way to go then ?

Best regards,

Maxime
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help