On 2023/6/30 2:08, Jakub Kicinski wrote:

On Wed, 28 Jun 2023 18:01:16 +0800 Zhengchao Shao wrote:

quoted

The line cards array is not freed in the error path of
mlxsw_m_linecards_init(), which can lead to a memory leak. Fix by
freeing the array in the error path, thereby making the error path
identical to mlxsw_m_linecards_fini().

Fixes: 01328e23a476 ("mlxsw: minimal: Extend module to port mapping with slot index")
Signed-off-by: Zhengchao Shao <redacted>
Reviewed-by: Petr Machata <petrm@nvidia.com>

Could you please resend with Ido's review tag included?

  OK，I will resend this patch. Thank you.

Zhengchao Shao

Due to unforeseen mail server issues (it wouldn't be a merge window
without vger imploding, eh?) the patch did not make it to patchwork
or email archives.