Re: [PATCH net] ibmvnic: Do not reset dql stats on NON_FATAL err
- From
- Jakub Kicinski <kuba@kernel.org>
- Date
- 2023-06-24 22:19:12
- Reply to
- Nick Child, 2023-06-22
On Thu, 22 Jun 2023 14:03:32 -0500 Nick Child wrote:
quoted hunk ↗ jump to hunk
+ if (adapter->reset_reason == VNIC_RESET_NON_FATAL) + clear_bit(__QUEUE_STATE_STACK_XOFF, + &netdev_get_tx_queue(netdev, i)->state);
Why are you trying to clear this bit?
If the completions will still come the bit will be cleared (or not)
during completion handling (netdev_tx_completed_queue() et al.)
Drivers shouldn't be poking into queue state bits directly.
--
pw-bot: cr