Re: [PATCH net-next 1/3] iavf: add check for current MAC address in set_mac callback
From: Simon Horman <hidden>
Date: 2023-06-03 14:07:12
From: Simon Horman <hidden>
Date: 2023-06-03 14:07:12
On Fri, Jun 02, 2023 at 10:13:00AM -0700, Tony Nguyen wrote:
From: Piotr Gardocki <redacted> In some cases it is possible for kernel to come with request to change primary MAC address to the address that is actually already set on the given interface. If the old and new MAC addresses are equal there is no need for going through entire routine, including AdminQ and waitqueue. This patch adds proper check to return fast from the function in these cases. The same check can also be found in i40e and ice drivers. An example of such case is adding an interface to bonding channel in balance-alb mode: modprobe bonding mode=balance-alb miimon=100 max_bonds=1 ip link set bond0 up ifenslave bond0 <eth> Signed-off-by: Piotr Gardocki <redacted> Reviewed-by: Michal Swiatkowski <redacted> Tested-by: Rafal Romanowski <redacted> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Reviewed-by: Simon Horman <redacted>